search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
311 stars 131 forks source link

Document changes to sorting icons and icon component #812

Open maxwondercorn opened 2 years ago

maxwondercorn commented 2 years ago

Document changes to icon parameters and required icon component

RobbieTheWagner commented 2 years ago

@maxwondercorn I'm not sure if we need to make these updates? We're using the same API as before, we're just now passing components instead of classes. If someone wanted to pass just the classes, they could and they could include their own CSS to make those classes add icons.

maxwondercorn commented 2 years ago

@rwwagner90 I see what you're saying about being able still use classes. A case of overthinking. I think we should be less font awesome specific. Something more generic such as "class names to use with custom CSS, web fonts, or ids to use with a custom icon component"

This is related to the incomplete upgrade guide. I call out using the included font awesome icons require implementing the fa-icon-wrapper or similar component, need to add your own icon packs to use other icons, etc.

I'll get back to this

RobbieTheWagner commented 2 years ago

@maxwondercorn yes, I agree. Perhaps we should move all the FA deps to devDeps and update the docs to be more generic, but also show a new FA example.

maxwondercorn commented 2 years ago

@maxwondercorn yes, I agree. Perhaps we should move all the FA deps to devDeps and update the docs to be more generic, but also show a new FA example.

I agree as that looks like the original implementation.