search

adopted-ember-addons / ember-light-table

Lightweight, contextual component based table for Ember
http://adopted-ember-addons.github.io/ember-light-table/
MIT License
311 stars 131 forks source link

Fix: Add ...attributes to lt-body #825

Closed IgnaceMaes closed 1 year ago

IgnaceMaes commented 1 year ago

In MR https://github.com/adopted-ember-addons/ember-light-table/pull/798/ the lt-body component has been made tagless. As the template doesn't contain ...attributes it's impossible to e.g. set an id or pass a modifier on the body. Is this an intention breaking change?

If not, this adds it back like it used to work in v3.0.0-beta.0.

IgnaceMaes commented 1 year ago

FYI @rwwagner90, as mentioned on Discord

RobbieTheWagner commented 1 year ago

@IgnaceMaes I think this needs a rebase now that CI is green.

IgnaceMaes commented 1 year ago

Synced the fork via GitHub, that should do it?