search

adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Apply readOnly to all computeds #214

Closed kellyselden closed 2 years ago

kellyselden commented 7 years ago

The industry is moving towards readOnly computed macros: https://github.com/emberjs/ember.js/issues/9290 https://github.com/stefanpenner/ember-improved-cp#readonly-by-default https://github.com/kellyselden/ember-awesome-macros/blob/8b38a000e4248d2855e15081af9553bee63abe88/addon/utils.js#L18

Just want to suggest doing it here too. Would be a breaking change.

In awesome macros, I escape the setting via writable. I can expose this to our common helper, which would be opt-in setting for people that want it here.

jasonmit commented 7 years ago

Sounds good, we should add some deprecation warnings ahead of it.

NullVoxPopuli commented 2 years ago

computed macros have been removed in v9 :D