converted moment-subtract and moment-add to use moment service

adopted-ember-addons / ember-moment

MIT License

399 stars 122 forks source link

Closed mfeltz closed 7 years ago

mfeltz commented 7 years ago

Updated helpers moment-add and moment-subtract to use the moment service to persist the locale change on the service.
Added the moment service into each of the tests for both helpers.

Reference issue #196

jasonmit commented 7 years ago

LGTM, #196 I do intend to set the locale on the moment global. I just haven't had the time to PR it yet. If you wanted to take that on please do :)

mfeltz commented 7 years ago

thanks! I'll submit a PR to update a couple more of the helpers to use the service and take a look at setting it globally.

jasonmit commented 7 years ago

@mfeltz much appreciated, thanks a lot :)