search

adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Convert code to RFC #176 imports #256

Closed aureliosaraiva closed 7 years ago

aureliosaraiva commented 7 years ago

RFC #176 introduces new modular imports so that you can import only the parts of Ember that you require inside that file.

jasonmit commented 7 years ago

Thanks!

jasonmit commented 7 years ago

@Turbo87 you mentioned a few weeks ago on ember-intl that the app tree shouldn't be converted - is that still an issue?

aureliosaraiva commented 7 years ago

@jasonmit @Turbo87 I'm updating some projects that are heavily used.

If you have any other projects that you believe are necessary, please let me know. I have some free time.

Turbo87 commented 7 years ago

@jasonmit yes, the transpilation of the app folder is not controlled by the addon, so compatibility with the new imports in the app folder can not be ensured

jasonmit commented 7 years ago

@Turbo87 thanks, I'll revert those bits.

/cc @aureliosaraiva

aureliosaraiva commented 7 years ago

Ok, only revert to / app? @jasonmit @Turbo87

jasonmit commented 7 years ago

@aureliosaraiva https://github.com/stefanpenner/ember-moment/commit/d78ebd0067fd55da685f2bf05d17c0565cfc69e7 should cover that