search

adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Assertion errors in Ember 3.10 - can be fixed in later ember-macro-helpers version #308

Open xtagon opened 5 years ago

xtagon commented 5 years ago

Hi,

ember-moment 7.8.1 depends on ember-macro-helpers ^2.1.0, but ember-macro-helpers fixed an Ember 3.10 incompatibility in 3.1.0 and up.

Would it be possible to update ember-moment to use the latest ember-macro-helpers, or loosen the dependency so that either may be allowed?

Thanks!

enspandi commented 5 years ago

Meanwhile you can try to add a resolution to package.json, like: 

"resolutions": {
    "ember-macro-helpers": "^4.0.0"
  },
xtagon commented 5 years ago

I'll give it a try.

xtagon commented 5 years ago

Looks like it works - thanks for that 👍