search

adopted-ember-addons / ember-moment

MIT License
400 stars 122 forks source link

[BREAKING] upgrade ember-macro-helpers to ^4.0.0 #312

Closed jelhan closed 4 years ago

jelhan commented 5 years ago

Outdated version of ember-macro-helpers breaks Ember 3.10. It was fixed in v3.1 by https://github.com/kellyselden/ember-macro-helpers/pull/260.

Subtletree commented 4 years ago

Anything preventing this from being merged? Let me know if I can help

jasonmit commented 4 years ago

@Subtletree no - just needs to be merged as a new major

jasonmit commented 4 years ago

Merged https://github.com/stefanpenner/ember-moment/pull/314 which resolves this (only reason I took that PR was that it bumped the engine in pkg.json also.

jasonmit commented 4 years ago

v8.0.0 was released

Subtletree commented 4 years ago

awesome ty!!