adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Update dummy app so that we can test against Octane+ #355

Closed NullVoxPopuli closed 3 years ago

NullVoxPopuli commented 3 years ago

Breaking Changes:

Drop support for:

in ember-moment@v9+, only ember-source >= 3.16 will be supported. ember-moment@v8 will still support ember-source < 3.12 and will still receive bugfixes over time -- this code has been branched to the ember-classic branch the ember-moment repo.

Why?

sly7-7 commented 3 years ago

@NullVoxPopuli It looks like a good start, and yes pretty much what I tried to do in my repo. If I understand well, the point here is to update the code/tests to make them pass ?

I don't know if you want, nor if it's possible, but maybe I could work on that pr, and close mine ?