search

adopted-ember-addons / ember-moment

MIT License
400 stars 122 forks source link

[chore] removes `ember-cli-moment-shim` references #367

Closed jfdnc closed 2 years ago

jfdnc commented 2 years ago

Recent removal of ember-cli-moment-shim had the side-effect of removing access to includeTimezone and includeLocales functionality. Remaining README references should be removed to reflect current ember-moment functionality.

I looked into potential paths forward in this issue thread, and it appears that we'll need to do another major version bump of ember-auto-import to reintroduce dynamically importing timezone and selected locale features. I suspect that there are some projects depending on this addon that are now unknowingly importing more than they expect (due to default timezone inclusion), so it may be valuable to pursue that, depending on maintainers' interest in a breaking release with ember-auto-import 2+.

ghost commented 2 years ago

I'll bite -- why does your link send me to the IMDB for Troll 2?

jfdnc commented 2 years ago

I'll bite -- why does your link send me to the IMDB for Troll 2?

LOL, that was entirely unintentional, but it brings me joy nonetheless! I'll find the intended link to when moment shim was removed.

jfdnc commented 2 years ago

Ok! OP link corrected, thanks for catching that 😅

For posterity, here's a link to the Trolls 2 IMDB page.

NullVoxPopuli commented 2 years ago

Since recent updates, I think this section: https://github.com/adopted-ember-addons/ember-moment#using-momentjs-in-ember-apps--addons

covers the timezone vs non-timezone usage workflow/options