search

adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Is ember-cli-moment-shim still required for ember-moment? #369

Open rreckonerr opened 2 years ago

rreckonerr commented 2 years ago

Hi! Thanks for taking care of this addon! I wonder whether the https://github.com/jasonmit/ember-cli-moment-shim is still required for ember-moment?

In case it DOES NOT, should we remove the blueprint?

In case it DOES, should we update ember-cli-moment-shim to the latest v3.8.0 in the blueprint?

ember-cli-moment-shim v3.4.0 is a blocker for upgrading to the latest ember versions since it relies on ember-cli-babel@6.6.0.

ATM I upgraded to the latest ember-moment v9.0.1, removed ember-cli-moment-shim, and don't see any downsides so far.

jrjohnson commented 2 years ago

I'm seeing the same and trying to figure out if I need to put time into updating and maybe maintaining moment-shim. It doesn't seem to be necessary possibly due to auto-import or something else?

NullVoxPopuli commented 2 years ago

You both are correct, shim is no longer needed.

jrjohnson commented 2 years ago

It looks like v10 now provides the tools/documentation needed to provide timezones and locales which were the last parts I was having trouble removing.