search

adopted-ember-addons / ember-moment

MIT License
399 stars 122 forks source link

Update internally used node to 18.x #402

Closed mkszepp closed 3 months ago

mkszepp commented 3 months ago

This is the first of some PR, to get CI green & bring the addon to addon v2 blueprint.

We start to drop node < 18, this should already bring a green CI for our tests ember < 3.28. The other do still fail, because we need more changes

Next steps are described here https://github.com/adopted-ember-addons/ember-moment/pull/378#issuecomment-2186899845

NullVoxPopuli commented 3 months ago

Up next: adding @ember/string to the test app

NullVoxPopuli commented 3 months ago

With the merge of https://github.com/adopted-ember-addons/ember-moment/pull/411, we longer have an engines field, so there should not be any dependence on any node version anywore.