search

adopted-ember-addons / ember-notify

Notification messages for your Ember.js app
MIT License
264 stars 100 forks source link

Update `ember-cli` and dependencies #152

Closed btecu closed 3 years ago

lrdiv commented 4 years ago

I'm attempting to pick this up and update tests, but I'm spinning my wheels trying to rewrite this block using the new test APIs https://github.com/adopted-ember-addons/ember-notify/blob/master/tests/unit/components/ember-notify-test.js#L16-L21

btecu commented 4 years ago

@lrdiv is the rendering test not covered by those tests using testLevelMethod? Thanks for picking this up!

lrdiv commented 4 years ago

@lrdiv is the rendering test not covered by those tests using testLevelMethod? Thanks for picking this up!

I'm not really sure. It's confusing that the tests in tests/unit/components are currently like hybrid unit-integration tests where they seem to depend on rendering, but also want to access the instance being tested. Maybe I'm just not understanding because I haven't seen unit tests like this before

btecu commented 4 years ago

This project was started a long time ago (January 2014) so a lot of things have evolved in Ember but it's possible that the project did not keep up with all the updates.