search

adopted-ember-addons / ember-notify

Notification messages for your Ember.js app
MIT License
264 stars 100 forks source link

DEPRECATION: `hasBlock` is deprecated. Use `has-block` instead. #163

Closed esbanarango closed 3 years ago

esbanarango commented 3 years ago

DEPRECATION:

hasBlock is deprecated. Use has-block instead. ('ember-notify/templates/components/ember-notify/message.hbs' @ L1:C6) [deprecation id: has-block-and-has-block-params] See https://emberjs.com/deprecations/v3.x#toc_has-block-and-has-block-params for more details.

bertdeblock commented 3 years ago

@btecu I see you made a commit for this deprecation on your fork. Were you planning on making a PR for this? Otherwise I can do this as well.

btecu commented 3 years ago

@bertdeblock I merged that pull request. The change likely requires a major release, since hasBlock was deprecated recently. However, to release a new version we should fix the tests (https://github.com/adopted-ember-addons/ember-notify/issues/136). Would you be able to help with that?

bertdeblock commented 3 years ago

Thanks for merging! I don't think it requires a major release though. {{hasBlock}} was an alias for calling {{has-block}} without a block name or for calling it with the block name default.

btecu commented 3 years ago

@bertdeblock 6.0.1 has been released.

esbanarango commented 3 years ago

Thank you 🙏