search

adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

remove @class #1123

Closed betocantu93 closed 4 years ago

betocantu93 commented 4 years ago

...attributes pass down the class from the invokation

miguelcobain commented 4 years ago

I'm keeping the class because I'm aiming for backwards compatibility. This way {{#paper-select class="something"}} would still work.

betocantu93 commented 4 years ago

@miguelcobain oh I see, talking about backwards compatibility I also think we should use this.variable on templates for this matter (even if they are conceptually args), since in 3.16 accessing variables in templates via @ do mean arguments, for me it was a pain to refactor because I had at least a 5 EP components extended which relied in setting defaults (i.e label) if none provided, because of this, I would strongly suggest to make a major release of this changes (when using @ notation)