search

adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

Fix[1134] mouseEnter/Leave/Move deprecations by adding event listeners #1135

Closed Shajansheriff closed 4 years ago

Shajansheriff commented 4 years ago

Fix 1134

betocantu93 commented 4 years ago

interesting, I didn't realized you could write native class for mixins!

Shajansheriff commented 4 years ago

@betocantu93 We have to replace mixins with native class or with some other patterns. Mixins are going to be removed, however we need to have a roadmap for refactor, because we are using quite a handful of mixins in our addon.

Shajansheriff commented 4 years ago

@miguelcobain Do you have any idea why those two specific tests are failing? It is passing in my local.

miguelcobain commented 4 years ago

@Shajansheriff interesting workaround for the deprecation. That didn't cross my mind. The failing tests are unrelated, as you probably guess. Those tests are flaky, and I suspect are related to using ember vertical collection. Usually they pass after retrying them some times. Since it's related I'll merge this even if they don't pass.

alex9nadon commented 4 years ago

@miguelcobain Hi, did you plan to merge and create a new release?