search

adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

Update ember-basic-dropdown to remove deprecation warning #1179

Closed ohcibi closed 2 years ago

ohcibi commented 3 years ago

The warning was caused by an outdated version of ember-maybe-in-element.

bjornharrtell commented 3 years ago

Another reason to merge this is that ember-basic-dropdown 2.x is broken on ember-source 3.25.0 and forward. See https://github.com/cibernox/ember-basic-dropdown/issues/578#issuecomment-806063900.

bertdeblock commented 3 years ago

ember-basic-dropdown should remain under dependencies though? It's used directly here.

bjornharrtell commented 3 years ago

@bertdeblock I would think it should work and is more appropriate as a dev dependency? (Used in build not directly in runtime)

bertdeblock commented 3 years ago

Don't think so? If it would work listed under devDependencies that would probably be because ember-paper also depends on ember-power-select, which in turn depends on ember-basic-dropdown (and there it's listed under normal dependencies as well). ember-paper uses the <BasicDropdown> component directly so keeping it under dependencies is the right thing.

bertdeblock commented 3 years ago

I think you are confusing it with listing dependencies under devDependencies for a project?

bjornharrtell commented 3 years ago

@bertdeblock ah yes you are of course correct, my mistake. And I think it does not make much sense to update only one of these related components. I've started on https://github.com/miguelcobain/ember-paper/pull/1182 but it's not a trivial upgrade.

bjornharrtell commented 3 years ago

Discussed with @miguelcobain and since ember-paper is essentially in maintenance only mode it is better to solve this issue with a patch for ember-basic-dropdown v2 branch instead of attemping a large refactoring in ember-paper.