search

adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

Ghost basic-dropdown-content once paper-menu closed #1191

Closed dfriquet closed 2 years ago

dfriquet commented 3 years ago

Hello there!

We just discovered a bug in an app we develop for years now. A thorough test of the app after upgrading to Octane syntax revealed an annoying behaviour: once closed, the paper-menu-content <div> is cloned and left in place, invisible, on top of all the other GUI elements, catching all the clicks and preventing all interactions with the buttons behind.

On click, the menu opens:

ember-paper paper-menu open

On click outside, the menu closes but a cloned <div> is left behind:

ember-paper paper-menu ghost

DEBUG: Ember             : 3.18.1
DEBUG: Ember Data        : 3.18.0
DEBUG: jQuery            : 3.3.1
DEBUG: Ember Paper       : 1.0.0-beta.35

No related errors in the console.

This behaviour is present from the beta.23 at least. We just upgraded to the latest beta to see if it fixes it, but unfortunately not.

Have you ever stumbled upon this kind of trouble? Do you know how to fix it?

Thanks!

dfriquet commented 3 years ago

Hi @miguelcobain and al.!

I narrowed down the issue to this commit and the "animation disabling" lines. Moreover, this change introduces the paper-menu flying into screen issue too. I can't see any glitches without this @animationEnabled={{false}}.

Can you tell me what was the motivation for this?

Thank you for your time, I know there is not much left these days for you awesome ember-paper :+1: