adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

upgrade angular-material-styles to remove sass deprecation #1219

Open mansona opened 2 years ago

mansona commented 2 years ago

Hey folks 👋

As you can see by my last PR I'm in the mode of knocking off a few deprecations, and although I'm aiming to get Ember 4.0 functionality working there was quite a noisy deprecation coming from sass:

DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

I did some investigating and I found a version of the angular-material-styles repo that was compatible with our setup (but we would need to install it with github since they haven't released a version of angular-material-styles that fixes our particular issue.) https://github.com/angular/material

I did have to fork that to fix a preinstall script that is no longer relevant but other than that I think we're good to go 👍

I did a quick clicking through the demo app and I couldn't see any meaningful change to the styles but maybe you might have a better feel for this? I can confirm that this solves the SASS deprecation warning 👍

github-actions[bot] commented 1 year ago

Some tests with 'continue-on-error: true' have failed: