adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

allow full-screen snapshots #1301

Closed mansona closed 1 week ago

mansona commented 1 week ago

The original reason for this change is because I wanted to add percy in #1296 but this is also required if you want the chrome "full screenshot" functionality to work. You can compare the preview build of this PR with the main demo app by doing the following

On main you'll see that scroll will be cut off and you can never get a full screenshot. This PR fixes that but needs to add some hacks to make the dialog inert. Personally I think it's a good tradeoff 👍

netlify[bot] commented 1 week ago

Deploy Preview for ember-paper ready!

Name Link
Latest commit cc4e193dce92577776ff7cbb07df91f2ff1b3ea7
Latest deploy log https://app.netlify.com/sites/ember-paper/deploys/67344c0265314d0008d8dea3
Deploy Preview https://deploy-preview-1301--ember-paper.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 week ago

Some tests with 'continue-on-error: true' have failed: