adopted-ember-addons / ember-paper

The Ember approach to Material Design.
https://ember-paper.netlify.app/
MIT License
888 stars 333 forks source link

SCSS structure & Guidelines #80

Closed bj-mcduck closed 9 years ago

bj-mcduck commented 9 years ago

Ahoy! I'm interested in contributing.

I'd like to know if you're using any specific SCSS structure, like SMACSS, BEM, or OOCSS.

Cheers

miguelcobain commented 9 years ago

Hi! Contributions are so much welcome!

Thank you for your interest!

bj-mcduck commented 9 years ago

@miguelcobain I was just noticing now that there's some variance in what names the CSS styles get.

I see somethings like md-icon as a tag name, and paper-icon as the class name. Where as md-checkbox has both tag name, and class name the same.

This could cause some confusion down the road. It may not be huge priority right now, but I was thinking I could create a wiki page for contributing so it'd be easier to keep it updated (doesn't require a PR, or push to update it). We don't necessarily need to go update all the current components to match immediately after deciding, but if we come up with a convention now there'll at least be a consistent expectation set going forward of how to code it, and how to style it in app.

Personally, I'd like to start forming an outline on how to answer questions like:

Specifically that last one is another talking point. md- is great because it's so short, but it is primed to conflict with the expected xs, sm, and md breakpoints found in many other frameworks.

Anyway, lots of thoughts here... but figured I should post it for discussion.

bj-mcduck commented 9 years ago

I also whipped together this PR to provide some better structure for the scss files.

I could address some other organization changes in it if anything comes of this discussion.