search

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.
MIT License
158 stars 169 forks source link

Deprecation Warning: didUpdateAttrs will stop receiving arguments #147

Closed tsteuwer closed 7 years ago

tsteuwer commented 7 years ago

https://emberjs.com/deprecations/v2.x/#toc_arguments-in-component-lifecycle-hooks

DEPRECATION: [DEPRECATED] Ember will stop passing arguments to component lifecycle hooks. Please change `<app-name-here@component:pikaday-input::ember885>#didUpdateAttrs` to stop taking arguments. [deprecation id: ember-views.lifecycle-hook-arguments] See http://emberjs.com/deprecations/v2.x/#toc_arguments-in-component-lifecycle-hooks for more details.
        at logDeprecationStackTrace (http://172.19.15.43:4200/assets/vendor.js:23441:19)
        at HANDLERS.(anonymous function) (http://172.19.15.43:4200/assets/vendor.js:23651:7)
        at raiseOnDeprecation (http://172.19.15.43:4200/assets/vendor.js:23471:12)
        at HANDLERS.(anonymous function) (http://172.19.15.43:4200/assets/vendor.js:23651:7)
        at invoke (http://172.19.15.43:4200/assets/vendor.js:23667:7)
        at deprecate (http://172.19.15.43:4200/assets/vendor.js:23536:32)
        at Object.deprecate (http://172.19.15.43:4200/assets/vendor.js:23975:37)
        at Class.exports.default._emberMetal.Mixin.create._Mixin$create.init (http://172.19.15.43:4200/assets/vendor.js:59548:17)
        at Class.superWrapper (http://172.19.15.43:4200/assets/vendor.js:58549:22)
duizendnegen commented 7 years ago

Welcoming a PR :)

tsteuwer commented 7 years ago

@duizendnegen looking into it ;)

tsteuwer commented 7 years ago

@duizendnegen done and done!