search

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.
MIT License
158 stars 169 forks source link

upgrading ember-cli-moment-shim to 3.8.0 #392

Closed validkeys closed 9 months ago

validkeys commented 4 years ago

ember-cli-moment-shim 3.8.0 contains bug fixes for production builds. After upgrading my local app to that version of ember-cli-moment-shim, my production builds had an older version of moment that I tracked down to ember-pikaday. All tests passed locally.

validkeys commented 4 years ago

The above errors appear to be from yarn caching / not removing previous node_modules. moment@2.24 introduced a locale en-SG.js. Not sure what to do here...

MelSumner commented 9 months ago

This dependency is no longer used in this addon, closing PR (apologies that it took so long)