Use luxon - Githubissues

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.

MIT License

159 stars 169 forks source link

Use luxon #519

Open robinvrd opened 3 years ago

robinvrd commented 3 years ago

Althought moment.js works well with pikaday.js, it is now deprecated and has to be replaced with an alternative like luxon (basically its successor from same team).

Packages installation

ember-auto-import (and webpack) were necessary to use luxon
testdouble was causing troubles with webpack and its use was pretty basic (so replaceable)
current version of ember-cli-babel was causing issues with webpack

Changes

luxon follows ISO weekdays order so we had to change all about firstDay as Monday is now 0 (and not 1)
luxon uses other formatting tokens so we had to change all about format (https://moment.github.io/luxon/docs/manual/formatting.html#table-of-tokens)
As pikaday has an natural integration with moment.js but not with luxon, we had to use pikaday methods toString and parse (https://github.com/Pikaday/Pikaday#formatting)

lifeart commented 2 years ago

Hi @robinvrd! Thank you for your work!

Wondering, could it be config option to use? Instead of dropping of moment-js according to scope of change, looks like we could support both, and use moment or luxon as transitive dependencies

just replacing moment to luxon looks like huge breaking change, and that's MR is not merged or reviewed (likely)

ember-power-calendar has a similar concept, you can use it with moment, luxon or date-fns.