fix(modifier): ensure compatibility with ember-modifier v4

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.

MIT License

159 stars 169 forks source link

fix(modifier): ensure compatibility with ember-modifier v4 #540

Closed anehx closed 1 year ago

anehx commented 1 year ago

This PR converts the pikaday modifier to use the new ember-modifier API introduced in v3.2.0. I migrated the modifier using this guide here.

patrickberkeley commented 1 year ago

@anehx we're running into the compatibility issue you've fixed here. Any chance you can move this forward?

tcjr commented 1 year ago

@anehx Is there anything blocking this from being merged? I would be happy to help in any way I can.

anehx commented 1 year ago

@tcjr @patrickberkeley I don't have any permissions on this repo so I can't really push this forward. Since I waited too long for a response we dropped ember-pikaday in favor of ember-flatpickr..

renaudleo commented 1 year ago

@SergeAstapov Anything we can do to help merging this? 🙂