search

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.
MIT License
159 stars 169 forks source link

Update ember-modifier to allow 4.x #550

Open cah-brian-gantzler opened 1 year ago

cah-brian-gantzler commented 1 year ago

Please extend the range of ember modifier to use 3.x and 4.x

tythewebguy commented 10 months ago

I just wasted way too much time troubleshooting why ember-pikaday broke during my Ember 4 upgrade only to discover this fix has been committed to master but a new version has not been released. A version 4.0.1 would be really nice.

cah-brian-gantzler commented 10 months ago

:) Pretty sure I asked already a couple times to have a new release. You said ember 4, but think you mean ember-modifier 4 and yes, waiting on the same thing.

tythewebguy commented 10 months ago

I'm in the process of upgrading our project to Ember 4 and yes, ember-pikaday broke because of the ember-modifier version. Your post here helped me figure out the problem and get it fixed. You saved me a lot frustration—THANK YOU!

cloutierlp commented 9 months ago

It would be a real pleasure to see this problem resolved. This seems to be already fixed in master. Is this just a release that needs to be done?

Can we help in any way?

herzzanu commented 6 months ago

Does the latest release fix this?

cah-brian-gantzler commented 6 months ago

I believe it does.

However now the `@ember/test-helpers' could use its range extended to include 3