Bug: updated tests - Githubissues

adopted-ember-addons / ember-pikaday

A datepicker component for Ember CLI projects.

MIT License

159 stars 169 forks source link

Bug: updated tests #569

Closed MelSumner closed 5 months ago

MelSumner commented 5 months ago

This will end up being a major because we had to bump the node version.

Changes:

updated the package.json file so the scripts were sorted alphabetically.
consolidated node versions to latest LTS
updated specific dependencies
removed the 3.25 scenario
moved from testdouble to sinon

CleanShot 2024-01-23 at 09 49 48

Everything is passing locally but not here, so I think we need to figure out what must pass to get the next release out, and then what needs to be fixed after that.

knownasilya commented 5 months ago

Would this be a major version change since the node version is being updated?

MelSumner commented 5 months ago

@knownasilya we might need to make it one.

I'm trying to get the tests to pass and only upgrading what I need to do, in order to make that happen. WDYT?

knownasilya commented 5 months ago

I'm fine with bumping a major, plenty of numbers to go around. It'll be an easy upgrade if that's the only change. Looks like the GH actions workflow is busted too.

MelSumner commented 5 months ago

ok I'll look at that too. Do you think it wants a specific version number of Node or is =>16 type of change good enough?

MelSumner commented 5 months ago

Yeah, I just looked at it and I have no idea why. It looks like it should be fine?

MelSumner commented 5 months ago

ok reverting the node change worked, but it looks like it is trying to test against 3.25 which I think we should just make it 3.28 or higher for this one. Would that also mean a major? not sure.

knownasilya commented 5 months ago

Yes a major would be required for that. Probably need to upgrade node for CI too.

knownasilya commented 5 months ago

Nice @MelSumner