Automatically updating values to the min/max date creates exceptions and potential infinite render in Ember Apps.

[Duder-onomy]

This issue occurs on the head of master.

There are only a handful of things that Ember-pikday does which Pikaday does not do. Specifically, this code here In the modifier's modify hook: https://github.com/adopted-ember-addons/ember-pikaday/blob/c3a00669a99c2c3af1a66f815bee2f4bd5fcce4a/src/modifiers/pikaday.js#L60

if (minDate && value && value < minDate) {
  value = minDate;
  valueAltered = true;
}

As detailed in the readme here, this code is a departure from Pikday, and its intention is to update the value to the minDate if the value is earlier than the minDate.

^ Since this code runs on the first modify and potentially the first render. It can cause infinite rendering issues as it will update a value in the same 'computation' or 'runloop' as the value is read.

This creates bugs in Ember apps.

( Here ^ when using changesets )

I suggest we remove these lines ( and the corresponding lines for maxDate ) as:

• they are a departure from stock Pikaday, a dev who knows Pikday would be surprised to see these changes.
• they cause bugs in ember apps
• it honestly might not be what we want. I can imagine a world where we will still want to show a selected date, earlier than a minDate... if only to show the users that it is invalid.

I am happy to pull request this change if there is consensus.

FWIW: Ember 4.12 Ember-pikaday latest master

[Duder-onomy]

Doing some digging, If you pull down the master branch, a fresh pnpm install + pnpm test... the tests will fail with this same error:

So. it seems like this behavior is also breaking the master branch of Ember-Pikaday

[MelSumner]

@Duder-onomy if you want to create a PR, I'd be happy to review it.

[Duder-onomy]

@MelSumner I was able to open what I think is the extent of the changes we need: https://github.com/adopted-ember-addons/ember-pikaday/pull/593 Running that code in my application solves the exceptions I was seeing.
Happy to update the PR with anything else you think we might need.
Tks for all your effort in the Ember world BTW!! Really do appreciate it.

[MelSumner]

Okay, release v.5.0.0, see if that fixes it for ya! TY for doing the work! https://github.com/adopted-ember-addons/ember-pikaday/releases/tag/v5.0.0-ember-pikaday

[Duder-onomy]

v5.0.0 works great. Thank you!