search

adopted-ember-addons / ember-qunit-nice-errors

Because expected true, result false is not enough!
http://wyeworks.github.io/ember-qunit-nice-errors/
MIT License
55 stars 12 forks source link

Update to ember-cli v2.18.0 #58

Closed san650 closed 6 years ago

san650 commented 6 years ago

No idea why eslint passes locally but it fails on codeclimate. I couldn't set a config for codeclimate that ignores some ember specific rules that don't apply to node-tests.

Can we merge this still?

fedekau commented 6 years ago

@san650 TravisCI fails because a chrome problem, see travis-ci/travis-ci/issues/8836, and the solution seems to be 852849ff. If you manage to fix that it would be great 😄 Code climate we can fix it afterwards, what do you think?

fedekau commented 6 years ago

Is your fork up-to-date? Because I remembered I already merged that fix I mentioned in the last comment 🤔