search

adopted-ember-addons / ember-qunit-nice-errors

Because expected true, result false is not enough!
http://wyeworks.github.io/ember-qunit-nice-errors/
MIT License
55 stars 12 forks source link

Allow to configure include and exclude rules #61

Closed san650 closed 6 years ago

san650 commented 6 years ago

Closes #20

fedekau commented 6 years ago

Is this ready to merge?

san650 commented 6 years ago

@fedekau it is! My only question/concern is if we should cache the minimatch matchers... I think it compiles them to a regex on each call.

Maybe this is a good first step and we can refine it later.

fedekau commented 6 years ago

@san650 I think it is fine as it is right now, we can come back on this if it turns out to be too slow