search

adopted-ember-addons / ember-sortable

Sortable UI primitives for Ember.js
https://ember-sortable.netlify.app/
MIT License
298 stars 148 forks source link

Allow @ember/test-helpers 3 #518

Closed francois2metz closed 1 year ago

francois2metz commented 1 year ago

@ember/test-helpers v3 has been released for a while.

francois2metz commented 1 year ago

Not sure which pnpm version was used to generate the lockfile. I setup pnpm@7.33.6, instead of the last one 8. It should works now.

francois2metz commented 1 year ago

I fixed a small when running tests with @ember/test-helpers v3. Should be good now!

francois2metz commented 1 year ago

Is there is any chance to merge it?

knownasilya commented 1 year ago

@francois2metz should it pass in ember-release?

knownasilya commented 1 year ago

Rerunning the tests made it pass, and it didn't seem related to your changes.

KroneckerDeIta commented 10 months ago

Can a release with these changes be published please? I am upgrading my project to Ember 5.4 and I am having to put the following into my package.json file so that an npm install goes through:

"overrides": {
    "ember-sortable": {
        "@ember/test-helpers": "^3.2.0",
        "ember-source": "~5.4.0"
    }
}