search

adopted-ember-addons / ember-sortable

Sortable UI primitives for Ember.js
https://ember-sortable.netlify.app/
MIT License
298 stars 148 forks source link

Update rootURL for gh-pages #569

Closed NullVoxPopuli closed 3 months ago

mansona commented 3 months ago

do we want to deploy this on netlify so that we can have preview urls on PRs?

NullVoxPopuli commented 3 months ago

do we want to deploy this on netlify so that we can have preview urls on PRs?

I'm anti netlify, but if you want to set it up, no objection!

Will need to delete the newly created: https://github.com/adopted-ember-addons/ember-sortable/blob/master/.github/workflows/deploy-gh-pages.yml haha

I cannot wait for the day gh-pages gets sub-sub-domains

branch.org.github.io/project

tho, I'd prefer the re-do their strategy and do: project.org.github.io, so that branch sub-domains (now sub-sub-sub) don't collide between projects

mansona commented 3 months ago

https://ember-sortable.netlify.app/ is deployed 👍

mansona commented 3 months ago

I'm anti netlify, but if you want to set it up, no objection!

So first of all, everyone is entitled to their opinions so I'm not trying to mitigate that. My personal opinion is that Netlify is absolutely fantastic and a really good thing for the web, especially for people getting started and wanting to get their apps in front of people. Netlify have also been very good to the Ember community with their provision of free hosting for all of our docs websites so I always have nothing but positive things to say about Netlify whenever I get a chance.

I understand that you are communicating a personal opinion when you say things like this, but I encourage you to think twice and be careful about what you say. You are a member of the Ember Core Tooling team, and whether you like it or not, your words carry an implicit weight of "I'm a member of the Ember Core team, and I believe ...".

The Ember Core team is very pro-Netlify and is grateful for everything that they have given Ember over the years 👍