search

adopted-ember-addons / ember-stripe-elements

A simple Ember wrapper for Stripe Elements
https://ember-stripe-elements.netlify.com
MIT License
19 stars 23 forks source link

fix: load environment config #29

Closed knownasilya closed 1 year ago

knownasilya commented 3 years ago

Without this change you must use .load(...) with the key and options. Basically making the config options useless.

st-h commented 2 years ago

Sorry about the late reply. I am not sure if I understand what the actual fix is. The load method provides two parameters, the publishable key and an option, that overrides config.stripeOptions. I am not sure what is going on, because I am using the publishableKey environment config, which is loaded in a similar manner to the stripeOptions, which seems to work without issues. Could you please elaborate?

However, I think we should continue to merge the develop branch into master, as the currently released version does not seem to work with ember 4 (just migrated my app to ember 4 and noticed that we should at least cut a new release based on the develop branch). At least I haven't run into any issues with using the develop branch in my app.

knownasilya commented 1 year ago

I believe this was fixed when everything was octanified..