search

adopted-ember-addons / ember-stripe-elements

A simple Ember wrapper for Stripe Elements
https://ember-stripe-elements.netlify.com
MIT License
19 stars 23 forks source link

New release from develop > 2.0.0 #31

Open evoactivity opened 2 years ago

evoactivity commented 2 years ago

It seems like an octane upgrade was merged to develop last Feb with plans to cut a new release.

I believe the new release as it currently exists would close #6 #27 #30

I will need to use this addon in the next few weeks/months so I may be able to spend time on this myself when I come to it on my current project, for example I think I could cover

  1. Updating the load method to use the official stripe loader as outlined in #25
  2. Adding a withRetry method to enable retrying a failed stripe load as outlined in #22
  3. Moving test support to addon-test-support dir as outlined in #21
  4. Adding the update method to the stripe mock to close #8
  5. Adding the new "Payment" element as a glimmer component https://stripe.com/docs/payments/payment-element

I can't start on this right away, but I do plan to come back and visit this when I get to the payments part of my current project.

st-h commented 2 years ago

Hey there, sorry, I've been busy with lots of other things. I think everything you mentioned sounds good so far. Would be awesome to see some progress with this addon. Otherwise, I think we should cut a release with the current develop branch (merge develop into master). The currently released version doesn't work with vertx 4. However, the develop branch seems to work fine, so we should take this as the basis for any further development.

Looking forward to your PRs.

st-h commented 2 years ago

I merged development into master and published a 2.0.1 release. I already fixed #21 (make sure test helpers don't end up in product build) as it was a quick change to make.