search

adopted-ember-addons / ember-stripe-elements

A simple Ember wrapper for Stripe Elements
https://ember-stripe-elements.netlify.com
MIT License
19 stars 23 forks source link

fix: deprecated EmberError #47

Closed eugenioenko closed 1 year ago

eugenioenko commented 1 year ago

Description

The module EmberError has been deprecated since ember 4.12: https://api.emberjs.com/ember/4.12/modules/@ember%2Ferror

Current import of EmberError is causing build fail when using ember-stripe-elements with Ember 5:

Error: Could not find module @ember/error imported from @adopted-ember-addons/ember-stripe-elements/services/stripev3

This PR replaces the EmberError by following the deprecation guide: https://deprecations.emberjs.com/v4.x/#toc_deprecate-ember-error

Use of @ember/error is deprecated. This package merely re-exports the native Error class. You should replace any uses of @ember/error with the native Error.

Because EmberError just reexported native Error, this fix should not cause any braking changes

josemarluedke commented 1 year ago

@knownasilya can you release a new version containing this PR?

knownasilya commented 1 year ago

Released