adopted-ember-addons / ember-validators

A collection of EmberJS validators
Other
24 stars 40 forks source link

The date validator has a different allowBlank validation #105

Open frykten opened 2 years ago

frykten commented 2 years ago

Hi! :wave:

While working with ember-changeset-validations, which uses this addon quite extensively, I saw there was an "inconsistency" in the behaviour of the date validator's allowBlank option, which checks nullish values and empty strings instead of using Ember's util isEmpty, as per all other validators (cf.). I also saw that was introduced when removing Moment (cf. commit). Was it meant to be?