search

adopted-ember-addons / ember-validators

A collection of EmberJS validators
Other
24 stars 40 forks source link

[BUGFIX] Use String.match instead of RegExp.test to support g flag #41

Closed offirgolan closed 7 years ago

offirgolan commented 7 years ago

Resolves offirgolan/ember-cp-validations#423.

@stefanpenner what do you think about this change? Are there any edge cases that might break this or will this cause any serious performance issues?

From my research, it looks like RegExp.test is a more optimal solution but it doesnt seem TOO significant.