adopted-ember-addons / ember-validators

A collection of EmberJS validators
Other
25 stars 40 forks source link

Update minimum version of ember-require-module #54

Closed jrjohnson closed 7 years ago

jrjohnson commented 7 years ago

This serves no purpose other than to make ember-dependency-lint happy. Without it I get

$ ember dependency-lint
ember-require-module
Allowed: (any single version)
Found: 0.1.2, 0.1.1
ilios
└─┬ ember-cp-validations
  ├── ember-require-module@0.1.2
  └─┬ ember-validators
    └── ember-require-module@0.1.1
simonihmig commented 7 years ago

Need this for the same reason! Tests seem to be broken for other reasons...

jrjohnson commented 7 years ago

I'm hoping @offirgolan can weigh in on test failures, I really have no idea why this bump would break them.

offirgolan commented 7 years ago

Woah sorry for the delay on this! For some reason I got no notification for this PR at all. Let me get this in to unblock you guys.

offirgolan commented 7 years ago

Released with v1.0.3.

jrjohnson commented 7 years ago

Not a problem, it's summer and I figure at least some people must be enjoying a holiday. Thanks for the quick release!