Upgrades + Embroider compatibility

adopted-ember-addons / ember-validators

A collection of EmberJS validators

Other

24 stars 40 forks source link

Upgrades + Embroider compatibility #92

Closed thoov closed 3 years ago

thoov commented 3 years ago

This PR includes:

ember-cli-upgrade changes
changes to addon/index.js such that there are no "dynamic" requires
adds @embroider/test-setup to ember-try's scenarios

Currently blocked by: embroider-build/embroider#826

Apart of: ember-cli/ember-cli#9536

snewcomer commented 3 years ago

@thoov

Should we throw in these changes to this PR as well? (still have to get past this "Required" check that is in the Settings tab that I don't have access to.). I can't see the travis run in the first place...

https://github.com/offirgolan/ember-validators/pull/93

snewcomer commented 3 years ago

I think we can give Github Actions a shot. The travis CI req has been removed!

snewcomer commented 3 years ago

👋 Any way I can help here?

josemarluedke commented 3 years ago

I'm also looking forward to this.