search

adopted-ember-addons / program-guidelines

Checklist and guidelines for the Adopted Ember Addons org.
MIT License
3 stars 5 forks source link

Migrate addons to GitHub Actions #18

Open jelhan opened 3 years ago

jelhan commented 3 years ago

In https://github.com/adopted-ember-addons/program-guidelines/pull/17 we decided to settle on GitHub Actions for CI. As a next step we should migrate all remaining apps to GitHub Actions. This issue is for tracking execution status:

patocallaghan commented 3 years ago

@jelhan I'm happy to migrate the factory-guy and model-fragments ones 🙋‍♂️ You mention an issue with the factory guy one being old, what's the problem there?

jelhan commented 3 years ago

@jelhan I'm happy to migrate the factory-guy and model-fragments ones :raising_hand_man: You mention an issue with the factory guy one being old, what's the problem there?

Great to hear that you can take over the two addons!

Factory guy is using a TravisCI configuration format created by Ember CLI < 3.4. Create-github-actions-for-ember-addon does not (yet) support migrating this old configuration format. It might be easier to use defaults and not migrate the TravisCI confiugration. To do so you need to delete the .travis.yml file before running yarn create github-actions-setup-for-ember-addon. The defaults should work very well in most cases. Scenarios are picked depending on config/ember-try.js. Node version is determined by engine in package.json. Etc. But I would recommend to double check the generated GitHub Action workflow twice. I haven't used that flow much yet.

gilest commented 3 years ago

@jelhan you can check off ember-file-upload (adopted-ember-addons/ember-file-upload/pull/429)

To migrate we: