search

adoptium / STF

The System Test Framework for executing https://github.com/adoptium/aqa-systemtest
Apache License 2.0
8 stars 35 forks source link

do not process stdderr when running df #125

Closed sxa closed 2 years ago

sxa commented 2 years ago

Fixes https://github.com/adoptium/infrastructure/issues/2508

This does mean stderr is likely to come out to the console somewhere, which is fine as I don't think the code looks explicitly for potential error messages. I don't believe any df command on any OS will be sending the "real" data to stderr so this fix should be fine everywhere.

Signed-off-by: Stewart X Addison sxa@redhat.com

smlambert commented 2 years ago

@sxa - looks like you have conflicts that need to be resolved.

Grinder links: on x64 Mac: https://ci.adoptopenjdk.net/job/Grinder/4226 on x64 Linux, x64 Windows: https://ci.adoptopenjdk.net/job/Grinder/4227

sxa commented 2 years ago

@sxa - looks like you have conflicts that need to be resolved.

Grinder links: on x64 Mac: https://ci.adoptopenjdk.net/job/Grinder/4226 on x64 Linux, x64 Windows: https://ci.adoptopenjdk.net/job/Grinder/4227

Ooooh don't think I've used comma-separated platforms before! Both runs LGTM. I'll resolve the conflicts now

pshipton commented 2 years ago

Since this change was merged, the OpenJ9 system tests are failing on Windows with messages like the following. @sxa @smlambert @llxia 

STF 10:20:50.742 - =========================   S T F   =========================
systemtest-prereqs has been processed, and set to: F:/Users/jenkins/workspace/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/jvmtest/system/systemtest_prereqsRetrieving amount of free space on drive containing F:/Users/jenkins/workspace/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/aqa-tests/\TKG\output_16487400461082\DaaLoadTest_all_CS_5m_0
There is 0 Mb free

Test machine has only 0 Mb free on drive containing F:/Users/jenkins/workspace/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/aqa-tests/\TKG\output_16487400461082\DaaLoadTest_all_CS_5m_0.

There must be at least 3Gb (3072Mb) free to be sure of capturing diagnostics
files in the event of a test failure.

Exiting.
pshipton commented 2 years ago

The first failure was https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly/237/ and contains this change. Last night they all failed. https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK8_x86-32_windows/710/ https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK8_x86-64_windows/853/ https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK11_x86-64_windows/902/ https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK17_x86-64_windows/510/ https://openj9-jenkins.osuosl.org/job/Pipeline_Build_Test_JDK18_x86-64_windows/78/

AdamBrousseau commented 2 years ago

If I roll back stf to dc841f7b01a138 it works

10:06:14  systemtest-prereqs has been processed, and set to: F:/Users/jenkins/workspace/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/jvmtest/system/systemtest_prereqsRetrieving amount of free space on drive containing F:/Users/jenkins/workspace/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/aqa-tests/\TKG\output_16488219673988\DaaLoadTest_all_CS_5m_0
10:06:15  There is 92881 Mb free

https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_extended.system_x86-64_windows_Nightly_testList_2/240/console