search

adoptium / TKG

TestKitGen (TKG)
Apache License 2.0
18 stars 98 forks source link

Update the --openjdk_testrepo arg name in runAqaArgParse.py #295

Open JeromeJu opened 2 years ago

JeromeJu commented 2 years ago

Describe the bug In the runAqaArgParse.py file, the --openjdk_testrepo arg name should be updated to --aqa-testrepo

Expected behavior The run-aqa should later take in --aqa-testrepo arg

JeromeJu commented 2 years ago

Hi, I was investigating the effect of the one-liner in #298 via the [similar workflow] (https://github.com/JeromeJu/TKG/runs/5554345670?check_suite_focus=true) as #297 in my forked TKG repo PR.

TODO：


usage: run aqa [--help]
 [--sdk_resource {nightly,releases,customized,build-jdk} [{nightly,releases,customized,build-jdk} ...]]
 [--build_repo BUILD_REPO [BUILD_REPO ...]]
 [--customized_sdk_url CUSTOMIZED_SDK_URL [CUSTOMIZED_SDK_URL ...]]
 [--archive_extension {.zip,.tar,.7z} [{.zip,.tar,.7z} ...]]
 [--build_list {openjdk,functional,system,perf,external} [{openjdk,functional,system,perf,external} ...]]
 [--target TARGET [TARGET ...]]
 [--platform PLATFORM [PLATFORM ...]]
 [--jdk_version JDK_VERSION [JDK_VERSION ...]]
 [--jdk_impl {hotspot,openj9} [{hotspot,openj9} ...]]
 [--openjdk_testrepo OPENJDK_TESTREPO [OPENJDK_TESTREPO ...]]
 [--openj9_repo OPENJ9_REPO [OPENJ9_REPO ...]]
 [--tkg_repo TKG_REPO [TKG_REPO ...]]
 [--workflow_repo WORKFLOW_REPO [WORKFLOW_REPO ...]]
run aqa: error: unrecognized arguments: --aqatest_repo adoptium/aqa-tests:master
JeromeJu commented 2 years ago

I checked again to make sure the checked out repo is the intended one. However, it still would not bring the correct output. As suggested from last meeting, shall we try merging this one-liner?