Open llxia opened 4 months ago
💯 agree, and recalling that we had long ago discussions of moving away from modes completely, since the variations within the playlist can be directly a set of VM options.
What modes really provides is a check on whether certain options are valid on certain platforms. Perhaps there is a different way to relate this information to test targets.
The mode is a short name for a list of jvm options. We inherited the old logic from vmfarm.
TKG/resources/modes.xml - defines the list of jvm options for each mode TKG/resources/ottawa.csv - defines what mode can or cannot run on which platforms. The complexity escalates when it needs to support 64_nocmprssptrs, cmprssptrs, and mixed JVM using one file. And support both internal (old Axxon) and external cases.
Due to the large number of columns and rows, it's difficult to discern what has been altered in the ottawa.csv file. And we had cases in which we had to revert change after merging. (see https://github.com/adoptium/TKG/pull/511). Also, it is hard to add new platforms.
Below are the platforms that we have so far:
I think we need to simplify ottawa.csv. To start, we could
default-64
anddefault-none64
should cover the regular cases.I am open to ideas of replacing ottawa.csv with a better solution.