Remove 3rd party jar version in fname - Githubissues

adoptium / TKG

TestKitGen (TKG)

Apache License 2.0

18 stars 98 forks source link

Remove 3rd party jar version in fname #541

Open llxia opened 7 months ago

llxia commented 7 months ago

By keeping 3rd party jar version in fname, we need to update all the references when we upgrade the jar.

https://github.com/adoptium/aqa-tests/pull/5270 ==> we need to update 15 reference lines

TODO:

remove 3rd party jar version in fname: https://github.com/AdamBrousseau/TKG/blob/master/scripts/getDependencies.pl#L188
update the references in https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml

judovana commented 7 months ago

But that is ok, inst it? Lets change it and we are done, or do I miss anything?

llxia commented 7 months ago

This is an enhancement and does not block the merge of https://github.com/adoptium/aqa-tests/pull/5270. Assuming this is what you are asking.

judovana commented 7 months ago

Oh that is clear. no reason to block that for sure. I'm just very slow to process how processes works. As I was studying jcstresses - https://github.com/adoptium/aqa-tests/issues/5261 - the individual steps may differ. I had already mentioned : https://github.com/AdamBrousseau/TKG/blob/master/scripts/getDependencies.pl#L188 in https://github.com/adoptium/aqa-tests/issues/5261 ; also It is clear if the jar is renamed, you have to change all fnames in https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml ... which I mentioned too. Or the name which is generated by https://ci.adoptium.net/view/Dependencies/job/dependency_pipeline/ will be adjusted to match what https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml needs. But that is up to discussion.

So there are now three issues, all about the same, and I'm not sure where to discuss what :)

Lemeri123 commented 2 days ago

is this issue still open?? so that I can work on it??