adoptium / TKG

TestKitGen (TKG)
Apache License 2.0
16 stars 94 forks source link

SysinternalsSuite.zip should be download via getDependencies.pl #559

Open llxia opened 1 month ago

llxia commented 1 month ago

Noticed in the job console that SysinternalsSuite.zip is downloaded at the runtimes and moved into testDependency\system_lib\windows_sysinternals. This is NOT due to this PR as SysinternalsSuite.zip is not even in the systemtest.getDependency job. However, we should handle this as well. I will open a separate issue for this.

00:08:47.503  configure-windows-sysinternals:
00:08:47.503       [echo] Executing macro download-file
00:08:47.503       [echo] File to download: https://download.sysinternals.com/files/SysinternalsSuite.zip
00:08:47.503       [echo] Destination: C:\temp\/windows_sysinternals/SysinternalsSuite.zip
00:08:47.503       [echo] Download tool: curl
00:08:47.503      [mkdir] Created dir: C:\temp\windows_sysinternals
00:08:47.503       [exec]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
00:08:47.503       [exec]                                  Dload  Upload   Total   Spent    Left  Speed
00:08:47.503       [exec] 
00:08:48.583       [exec]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 95 50.7M   95 48.5M    0     0  38.7M      0  0:00:01  0:00:01 --:--:-- 39.0M100 50.7M  100 50.7M    0     0  39.3M      0  0:00:01  0:00:01 --:--:-- 39.6M
00:08:48.583      [unzip] Expanding: C:\temp\windows_sysinternals\SysinternalsSuite.zip into C:\Users\jenkins\testDependency\system_lib\windows_sysinternals
00:09:12.595     [delete] Deleting directory C:\temp\windows_sysinternals

Originally posted by @llxia in https://github.com/adoptium/TKG/issues/533#issuecomment-2138056174

llxia commented 1 month ago

It would be nice to understand why we need SysinternalsSuite.zip in windows for system tests.