adoptium / adoptium.net

Adoptium Website
https://adoptium.net
Apache License 2.0
18 stars 109 forks source link

Update installation instruction to reflect Homebrew changes #2831

Closed RadekCap closed 2 months ago

RadekCap commented 2 months ago

Description of change

Relates #2817 This change reflects changed behavior on the brew.

Checklist

netlify[bot] commented 2 months ago

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
Latest commit cccd3d3977ad7d15bc9609bf7501058b35d9e5f8
Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/66313c4323e644000977834d
Deploy Preview https://deploy-preview-2831--eclipsefdn-adoptium.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.25%. Comparing base (b69b24b) to head (cccd3d3). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2831 +/- ## ======================================= Coverage 99.25% 99.25% ======================================= Files 89 89 Lines 6851 6851 Branches 602 602 ======================================= Hits 6800 6800 Misses 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karianna commented 2 months ago

I wonder if we do need to also add some instructions on how to remove the old cask references and move to the new ones. Is that something you could add as a callout?

RadekCap commented 2 months ago

:) I don't know where are old cask references stored. We even haven't decided what about upgrade. Do we need to cover it somewhere etc.

This PR is about an update to our documentation to the currently working solution.

It would be nice to find someone who has more experience with homebrew maybe.