search

adoptium / adoptium.net

Adoptium Website
https://adoptium.net
Apache License 2.0
18 stars 108 forks source link

Dropdowns don't reflect URL parameters #2843

Closed xavierfacq closed 2 months ago

xavierfacq commented 2 months ago

Description of change

Since we get data from the API, listboxes doesn't reflect url parameters #2841 and #2835

:warning: It should be good but I have to confirm if it's a problem with SEO.

NOTE: How does it work: OS and Arches are retrieved from the API, then it triggers a useEffect() to detect URL parameters and finaly it triggers the useEffect() that fetch data.

NOTE 2: Patch coverage is better than before on DownloadDropdowns component (Test Mac & Linux) :+1:

Checklist

netlify[bot] commented 2 months ago

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
Latest commit 523a634600725cde62aa0c20278ced875457644a
Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6638801f7c1863000862ae2d
Deploy Preview https://deploy-preview-2843--eclipsefdn-adoptium.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.50746% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.43%. Comparing base (036b3d5) to head (523a634). Report is 5 commits behind head on main.

Files Patch % Lines
src/components/DownloadDropdowns/index.tsx 98.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2843 +/- ## ========================================== + Coverage 99.25% 99.43% +0.17% ========================================== Files 89 89 Lines 6851 6880 +29 Branches 602 604 +2 ========================================== + Hits 6800 6841 +41 + Misses 51 39 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.