adoptium / adoptium.net

Adoptium Website

https://adoptium.net

Apache License 2.0

17 stars 108 forks source link

Update index.adoc #2906

Closed phil69210 closed 2 weeks ago

phil69210 commented 3 weeks ago

Added "sudo" before "tee" to make these commands run fine.

Description of change

Checklist

[ ] npm test passes
[ x] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[ ] contribution guidelines followed here

netlify[bot] commented 3 weeks ago

Deploy Preview for eclipsefdn-adoptium ready!

Name	Link
Latest commit	70e971d81c0b44f60d82aa267de2a9dec22c0ba6
Latest deploy log	https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/666a3d31e9550400085dbd32
Deploy Preview	https://deploy-preview-2906--eclipsefdn-adoptium.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.43%. Comparing base (cda5d70) to head (70e971d). Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2906 +/- ## ======================================= Coverage 99.43% 99.43% ======================================= Files 90 90 Lines 6956 6956 Branches 608 608 ======================================= Hits 6917 6917 Misses 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karianna commented 2 weeks ago

@gdams & @sxa - I'm in two minds about this, I know we have the guidance at the top but we still get a lot of support tickets from folks who CnP - thoughts on accepting this?

sxa commented 2 weeks ago

@gdams & @sxa - I'm in two minds about this, I know we have the guidance at the top but we still get a lot of support tickets from folks who CnP - thoughts on accepting this?

I'm personally 👎🏻 on this. Personally in many cases where I'm doing stuff like this I'm either already running as root or running in a minimal environment which may not have sudo installed, so I feel that forcing sudo into the command in the instructions is not the best way to approach this.

Further reasoning is in the PR where I removed the sudo parts from the commands, which this would revert: https://github.com/adoptium/adoptium.net/pull/477