adoptium / adoptium.net

Adoptium Website

https://adoptium.net

Apache License 2.0

17 stars 108 forks source link

[issue-2790] Correct pb with news pagination (change in API) #2928

Closed xavierfacq closed 2 days ago

xavierfacq commented 4 days ago

Description of change

NOTE: This is for #2790

I have corrected a pb with News pagination, it's ok now we can paginate. I have added a link "View all" under the pagination, to go to Eclipse website (like for events).

It also retrieves more news by call, 20 like for events.

Let me know if it's too much or OK. We can even reduce both to 10 or 5.

Checklist

[X] npm test passes
[ ] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[ ] contribution guidelines followed here

netlify[bot] commented 4 days ago

Deploy Preview for eclipsefdn-adoptium ready!

Name	Link
Latest commit	6907be9f40f77c40f1d07b9e2bdf8cb503c51351
Latest deploy log	https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6680135784ea9b0008b4240a
Deploy Preview	https://deploy-preview-2928--eclipsefdn-adoptium.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.44%. Comparing base (a029dca) to head (6907be9). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2928 +/- ## ========================================== - Coverage 99.44% 99.44% -0.01% ========================================== Files 90 90 Lines 6970 6968 -2 Branches 611 611 ========================================== - Hits 6931 6929 -2 Misses 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.