adoptium / adoptium.net

Adoptium Website
https://adoptium.net
Apache License 2.0
20 stars 113 forks source link

Java 23 EA missing on the nightly builds page #3016

Closed Peksa closed 1 week ago

Peksa commented 1 month ago

Describe the bug Java 23 (EA) missing on the nightly builds page - only Java 21, 22 & 24 are visible

To Reproduce

  1. Visit https://adoptium.net/temurin/nightly/
  2. Click the version drop-down
  3. Note that 23 - EA is missing

Expected behavior I expect to see a list with

24 - EA
23 - EA
22 
21 - LTS
etc..

Screenshots image

Additional context It's still possible to view the 23 nightly builds if you modify the URL to point at 23: https://adoptium.net/temurin/nightly/?version=23

xavierfacq commented 1 month ago

I'll take a look at this.

xavierfacq commented 1 month ago

First point: versions are retrieved from this endpoint: https://api.adoptium.net/v3/info/available_releases

No version 23 in the result image

The VersionSelector component is used in the Nightly builds.

xavierfacq commented 3 weeks ago

@gdams @johnoliver any idea why version 23 is not returned by the API?

johnoliver commented 2 weeks ago

So for ReleaseInfo.available_releases:

The versions for which adopt have produced a ga release

Since there have been no 23 GA releases it wont show up in the list. It would be possible to add a something for this such as:

In general I am not a fan of these, increasing the complexity/size of the API endpoints to support EA downloads is not a great ROI given how few people are interested in non-GA downloads. IMO the easiest would be simply for the website to assume that there are EA versions for versions between 16 and most_recent_feature_version, its a fairly safe assumption and even if it does not hold the user would just be presented with an empty list.

karianna commented 1 week ago

Is the simpler workaround here to have a static page / message to folks redirecting them to our slack for EA asks? I'm even hesitant to allow access to Jenkins here (a single script could spell doom)

smlambert commented 1 week ago

Is the simpler workaround here to have a static page / message to folks redirecting them to our slack for EA asks? I'm even hesitant to allow access to Jenkins here (a single script could spell doom)

Perhaps msg to redirect to website https://adoptium.net/temurin/nightly/?version=23 and https://adoptium.net/temurin/nightly/?version=24 for EA builds ?

smlambert commented 1 week ago

Ignore my comment above, was myopically responding to the comment without reading the full issue description!

xavierfacq commented 1 week ago

Hello,

:heavy_check_mark: Problem is fixed since this morning: https://adoptium.net/fr/temurin/nightly/?version=23 Look at the PR for more information.