search

adoptium / adoptium.net

Adoptium Website
https://adoptium.net
Apache License 2.0
21 stars 117 forks source link

Incorrect SHA shown for Red Hat marketplace binary #3221

Open tellison opened 4 days ago

tellison commented 4 days ago

Describe the bug The SHA value shown for the Red Hat build of OpenJDK is not correct on the Adoptium Marketplace website.

To Reproduce Load the marketplace webpage, e.g. https://adoptium.net/marketplace/?os=linux&package=jre&arch=x64

  1. Load the page then look at the Red Hat Checksum SHA256 value - it is blank.
  2. Look at another vendor's Checksum SHA and see the value.
  3. Look at the Red Hat SHA value in (1) again and it is the same as the value for vendor in (2).
  4. Look at another vendor's SHA value.
  5. Look at the Red Hat SHA value again and it is now the same as the vendor in step (4).

The Red Hat SHA value is just displayed as whatever was last viewed.

Expected behavior The marketplace website should show the correct SHA - or display an appropriate message if it is unavailable.

Desktop (please complete the following information): Believed to be on all.

Additional context Red Hat data source is https://github.com/rh-openjdk/marketplace

tellison commented 4 days ago

"sha256sum" is not being returned from marketplace API call

https://marketplace-api.adoptium.net/v1/assets/feature_releases/redhat/21?architecture=x64&image_type=jdk&os=linux

compare to Adoptium data call

https://marketplace-api.adoptium.net/v1/assets/feature_releases/adoptium/21?architecture=x64&image_type=jdk&os=linux

Two issues here:

  1. Why is the API not returning the sha256sum field?
  2. The website should not use 'old' values from other displays when an sha256 is not provided.
tellison commented 3 days ago

Cause of the first problem is https://github.com/adoptium/marketplace-api.adoptium.net/issues/542

Second problem for website code remains.